Hide progress bar on collection page if no estimated specimens count #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
|
This is a data entry issue, closing. See #251 for more details. |
|
Reopening due to additional context. See issue for details. |
adam-collins
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Records tab of the collection page there is a progress bar showing how many of the total/estimated number of specimens in the collection are available in the LA portal. However, if the total number of specimens is not available it defaults to displaying the message "No records are available for viewing..." which is often wrong and produces a very confusing page where the left part says there are a lot of records available and the right part says no records:
This PR fixes this by simply hiding the progress bar if the total/estimated number of specimens is not available since the progress bar makes no sense at all in that case.