-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/hcat #1591
Feature/hcat #1591
Conversation
…reference assessment controller class
… to referenceAssessment controller
…ded knockout lib to static page
…reference to common.js
…d integer casting of maxRecordsToCreate config property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. My general comments is to add a mongo script in release folder that will update the content of image assessment static page. See merit example here.
} | ||
|
||
def requestRecords() { | ||
def config = grailsApplication.config.refAssess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use getProperty
to get config items. grailsApplication.config.getProperty("refAssess", Map)
. A few instances of this are in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
chromedriver
build issues