Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jspecify annotations #2026

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Nov 10, 2024

@sullis
Copy link
Contributor Author

sullis commented Nov 13, 2024

WDYT? @hyperxpro

@hyperxpro
Copy link
Member

I think we should stick with JetBrains because it's widely used and integrates well with IntelliJ.

@hyperxpro hyperxpro requested a review from Copilot November 19, 2024 18:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 25 out of 40 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • client/pom.xml: Language not supported
  • client/src/main/java/org/asynchttpclient/cookie/ThreadSafeCookieStore.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/AsyncHandler.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClient.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/DefaultRequest.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/Request.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/Response.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/AsyncCompletionHandler.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/Realm.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/channel/ChannelPoolPartitioning.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/RequestBuilderBase.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/channel/NoopChannelPool.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/channel/ChannelPool.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java: Evaluated as low risk
  • client/src/main/java/org/asynchttpclient/filter/FilterContext.java: Evaluated as low risk
@hyperxpro
Copy link
Member

lol this thing is useless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants