Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions to calculate themal radiation flux #145

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

MasanoriKanamaru
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.10%. Comparing base (a42fc1c) to head (501475f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/radiation.jl 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   94.30%   94.10%   -0.20%     
==========================================
  Files          10       11       +1     
  Lines         685      696      +11     
==========================================
+ Hits          646      655       +9     
- Misses         39       41       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MasanoriKanamaru MasanoriKanamaru changed the title Functions to calculate black body radiation Functions to calculate themal radiation flux Aug 1, 2024
@MasanoriKanamaru MasanoriKanamaru marked this pull request as ready for review August 1, 2024 06:13
src/radiation.jl Outdated Show resolved Hide resolved
"""
println(msg)

@test AsteroidThermoPhysicalModels.blackbody_radiation(6e-7, 5850) ≈ 2.583616647617974e13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add comments to describe the meanings of the values?

MasanoriKanamaru and others added 2 commits August 14, 2024 16:40
src/radiation.jl Outdated Show resolved Hide resolved
Co-Authored-By: Yuto Horikawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants