Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dependencies of Luminol and it's crates #155

Merged
merged 15 commits into from
Aug 27, 2024

Conversation

somedevfox
Copy link
Collaborator

Connections
None

Description
Dependencies are declared in an illogical order in Luminol and it's crates (audio, config, etc.), which can make it hard to pinpoint them when needed. It's also a head-scratcher when you want to add a new dependency, because you don't know if you should place it in the end of the [dependencies] section or somewhere specific.

Testing

  • cargo build
  • trunk build

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown -Z build-std=std,panic_abort
  • Run cargo build --release
  • If applicable, run trunk build --release

@somedevfox somedevfox requested a review from a team as a code owner August 27, 2024 15:10
@melody-rs melody-rs merged commit 669c657 into Astrabit-ST:dev Aug 27, 2024
4 checks passed
@melody-rs melody-rs added the documentation Improvements or additions to documentation label Aug 27, 2024
@somedevfox somedevfox deleted the doc-deps branch August 27, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants