Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check icon #102

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Add check icon #102

merged 1 commit into from
Jan 17, 2024

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Jan 15, 2024 •
edited
Loading

Added the check icon

Screenshot 2024-01-14 at 7 24 31 PM

impelcrypto
impelcrypto approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if NPM works without updating version (in package.json)

@ayumitk ayumitk merged commit f172ef3 into main Jan 17, 2024
@ayumitk ayumitk deleted the feat/add-check-icon branch January 17, 2024 17:16
@ayumitk
Copy link
Contributor Author

ayumitk commented Jan 17, 2024

I'm not sure if NPM works without updating version (in package.json)

@impelcrypto FYI, I merged this PR, and then the release version on GitHub was automatically bumped and published to NPM without updating manually :)

@impelcrypto
Copy link
Member

@ayumitk Sorry, you are right! I've misunderstood with Astar-JS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@impelcrypto impelcrypto impelcrypto approved these changes

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@gluneau gluneau Awaiting requested review from gluneau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayumitk @impelcrypto @bobo-k2