Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional endpoint to return simple dapps list #107

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Sep 2, 2023

Created additional endpoint /api/v1/:network/dapps-staking/dappssimple to provide simplified list of daps with just mandatory properties. This optiomization will improve the portal performance and resolve problems with Token API handling large volume of data.

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Visit the preview URL for this PR (updated for commit caff6e0):

https://astar-token-api--pr107-feat-dapps-small-mod-mvyrqenr.web.app

(expires Sat, 09 Sep 2023 12:27:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f99fa4f4f8f3bb450e6e842f7e1c7783d6d896a3

Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Works.

curl 'http://127.0.0.1:5001/astar-token-api/us-central1/app/api/v1/astar/dapps-staking/dappssimple' | json_pp
...
[
   {
      "address" : "0x569b344ad6bf087a285f0d415d0066028921d873",
      "iconUrl" : "https://storage.googleapis.com/astarnetwork-a4924.appspot.com/astar-dapps%2F0x569b344ad6bf087a285f0d415d0066028921d873_icon-dark.b67724cc.svg",
      "mainCategory" : "defi",
      "name" : "ACryptoS"
   },
   {
      "address" : "0x1de7c3A07918fb4BE9159703e73D6e0b0736CaBC",
      "iconUrl" : "https://firebasestorage.googleapis.com/v0/b/astarnetwork-a4924.appspot.com/o/astar-dapps%2F0x1de7c3A07918fb4BE9159703e73D6e0b0736CaBC_rIb1fUz3_400x400%20(1).jpeg?alt=media&token=3832d94b-81bd-4e12-9d8b-96d83896ed3a",
      "mainCategory" : "tooling",
      "name" : "ADAO"
   },
   {
      "address" : "0x862e9ed0e5643dceb579fc31d59c6113ce2790d7",
      "iconUrl" : "https://storage.googleapis.com/astarnetwork-a4924.appspot.com/astar-dapps%2F0x862e9ed0e5643dceb579fc31d59c6113ce2790d7_Sygnet_B%20(2).png",
      "mainCategory" : "defi",
      "name" : "AI DEX AGGREGATOR"
   },
   {
      "address" : "0x22e1aa6bafb9965523cc33a5bfd2e4d3326a23e4",
      "iconUrl" : "https://storage.googleapis.com/astarnetwork-a4924.appspot.com/astar-dapps%2F0x22e1aa6bafb9965523cc33a5bfd2e4d3326a23e4_airlyft-logo-circle-high-res.png",
      "mainCategory" : "utility",
      "name" : "AirLyft.One"
   }
...

@bobo-k2 bobo-k2 merged commit aca903b into prod Sep 12, 2023
5 checks passed
@bobo-k2 bobo-k2 deleted the feat/dapps-small-model branch September 12, 2023 08:53
@bobo-k2 bobo-k2 mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants