refactor: wip #37
refactor: wip #37
Conversation
ts-ify & new boilerplate
tsconfig.json
Outdated
| "ES5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, | ||
| "module": | ||
| "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, | ||
| // "lib": [], /* Specify library files to be included in the compilation. */ |
There was a problem hiding this comment.
Though I know it's still in wip. Do we need any of these features or you plan to remove them up in future ?
There was a problem hiding this comment.
We need all of them.
|
@Kompwu I don't have any experience with ts. Earlier I only had heard about it. Now I see its various features. Looks good to me! 👍 Sorry for the late reply! |
|
Also I saw you removed yarn.lock. Any specific reason for that ? |
|
@Ashish-Bansal I'm gonna add a new one soon. |
@Kompwu Sure, how can I help you out ? |
|
@Ashish-Bansal |
|
@Ashish-Bansal Almost done :) |
Awesome! :D
Parcel seems to be more flexible than fusebox and requires less configuration boilerplate code than webpack, providing a nice middle ground. So, I would say let's try out Parcel. |
|
@Ashish-Bansal The problem is that with const fs = require('fs');
const manifest = require("./src/manifest.json");
const pkg = require("./package.json");
manifest["name"] = pkg["displayName"]
manifest["version"] = pkg["version"]
manifest['description'] = pkg['description'];
fs.writeFile('dist/manifest.json', JSON.stringify(manifest));And we run it at the same time as |
|
@Kompwu wow, parcel configuration is quite cleaner compared to webpack. Nice 👍 By the way, since we removed May be https://github.com/oncletom/crx would help. |
|
@Ashish-Bansal I'll see what I can do. |
|
Sure. |
|
@Kompwu Did you try loading extension in the browser ? I can see the paths are wrong in the manifest.json due to which it fails to load. |
|
@Ashish-Bansal Are you talking about the path for |
Yeah. Also, icons doesn't seem to load due to some reason. Though I haven't checked the reason for that yet. |
|
@Ashish-Bansal Apart from that, everything works for you? I've also made some performance improvements ;) |
|
@Kompwu No, it's throwing errors in background script.
Just did setup. Please share your username. Edit: Discord Channel link: https://discord.gg/Mm52n3Y |
|
@Ashish-Bansal Okay, i'm close. |
While the user is on the active YouTube video tab, continue playing the video, but as soon as the user moves to another tab, play only the audio. fix Ashish-Bansal#20
Use the "Ternary Operators" instead of "if".
|
@Ashish-Bansal What about #14? |
ts-ify & new boilerplate
Todo:
options.tsAnytypes to be more specific.ytp-right-controls.I've also added some githooks to automate some shit & lint commit.
@Ashish-Bansal What do you think? 🤔