Merge pull request #419 from Arquisoft/luis2

Arreglos de seguridad
Arquisoft · Apr 30, 2024 · f03caa7 · f03caa7
2 parents 1a506b1 + c1dd86f
commit f03caa7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/gatewayservice/gateway-service.js b/gatewayservice/gateway-service.js
@@ -112,13 +112,11 @@ app.get('/getAllGeneratedQuestions', async (req, res) => {
 
 app.get('/getRecords/:userId', async (req, res) => {
   try {
-
-    const userId = req.params.userId;
-
+    const userId = encodeURIComponent(req.params.userId);
     const recordsResponse = await axios.get(`${recordServiceUrl}/getRecords/${userId}`);
     res.json(recordsResponse.data);
   } catch (error) {
-      res.status(500).json({ error: 'Error interno del servidor' });
+    res.status(500).json({ error: 'Error interno del servidor' });
   }
 });
 

diff --git a/questions/generatedquestservice/generatedquest-service.js b/questions/generatedquestservice/generatedquest-service.js
@@ -25,8 +25,9 @@ mongoose.connect(mongoUri);
 const doesQuestionExist = async (questionBody) => {
   //devuelve true si la pregunta ya existe 
   try {
+    const safeQuestionBody = questionBody.toString();
     const existingQuestion = await GeneratedQuestion.findOne({
-      generatedQuestionBody: { $eq: questionBody }
+      generatedQuestionBody: safeQuestionBody
     });
 
     return !!existingQuestion; // Convertir el resultado en un booleano