Menos código duplicado

Arquisoft · Apr 7, 2024 · c6af312 · c6af312
1 parent f13cdbf
commit c6af312
Showing 1 changed file with 11 additions and 20 deletions.
diff --git a/gatewayservice/gateway-service.js b/gatewayservice/gateway-service.js
@@ -56,17 +56,21 @@ app.post("/adduser", async (req, res) => {
   }
 });
 
-app.get("/userInfo", async (req, res) => {
+const handleRequest = async (req, res, serviceUrl) => {
   try {
-    // Forward the question request to the user service
-    const userResponse = await axios.get(
-      userServiceUrl + "/userInfo",
-      { params: req.query }
-    );
-    res.json(userResponse.data);
+    const response = await axios.get(serviceUrl, { params: req.query });
+    res.json(response.data);
   } catch (error) {
     returnError(res, error);
   }
+}
+
+app.get("/userInfo", async (req, res) => {
+  handleRequest(req, res, userServiceUrl + "/userInfo");
+});
+
+app.get("/friends", async (req, res) => {
+  handleRequest(req, res, userServiceUrl + "/friends");
 });
 
 app.post("/saveGameList", async (req, res) => {
@@ -82,19 +86,6 @@ app.post("/saveGameList", async (req, res) => {
   }
 });
 
-app.get("/friends", async (req, res) => {
-  try {
-    // Forward the question request to the user service
-    const userResponse = await axios.get(
-      userServiceUrl + "/friends",
-      { params: req.query }
-    );
-    res.json(userResponse.data);
-  } catch (error) {
-    returnError(res, error);
-  }
-});
-
 app.get("/users/search", async (req, res) => {
   try {
     // Forward the question request to the user service