Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header tests added #76

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Header tests added #76

merged 3 commits into from
Mar 26, 2024

Conversation

krovostcora
Copy link
Contributor

Could you please check if tests look okay? Also, I've added to Header.js new attribute "data-testid" for tests

@krovostcora krovostcora requested review from Veneiro and Murias10 March 17, 2024 08:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Raulms29 Raulms29 merged commit 837497a into master Mar 26, 2024
1 of 2 checks passed
@Raulms29 Raulms29 mentioned this pull request Apr 10, 2024
Closed
@Murias10 Murias10 mentioned this pull request Apr 11, 2024
Closed
@Murias10 Murias10 deleted the frontend branch April 11, 2024 11:31
@Murias10 Murias10 mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raulms29 Raulms29 Raulms29 approved these changes

@Veneiro Veneiro Awaiting requested review from Veneiro

@Murias10 Murias10 Awaiting requested review from Murias10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krovostcora @Raulms29