Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc05 #19

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Doc05 #19

merged 4 commits into from
Feb 21, 2024

Conversation

didierrc
Copy link
Contributor

Finished Implementing Doc05

@didierrc didierrc linked an issue Feb 21, 2024 that may be closed by this pull request
Doc05 #16
Closed
Veneiro
Veneiro requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@Veneiro Veneiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a Template Database to the diagram which is going to be used by the QuestionGeneratorService and this service is going to be renamed to QuestionService

@Raulms29 Raulms29 requested a review from Veneiro February 21, 2024 16:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

carlosmndzg
carlosmndzg reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@carlosmndzg carlosmndzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine

@carlosmndzg carlosmndzg merged commit 7c6ca21 into master Feb 21, 2024
2 checks passed
@didierrc didierrc mentioned this pull request Feb 21, 2024
Closed
@Raulms29 Raulms29 mentioned this pull request Feb 21, 2024
Closed
@IyanRobles IyanRobles mentioned this pull request Feb 21, 2024
Closed
@carlosmndzg carlosmndzg mentioned this pull request Feb 21, 2024
Closed
@Murias10 Murias10 mentioned this pull request Feb 21, 2024
Closed
@Veneiro Veneiro mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raulms29 Raulms29 Raulms29 approved these changes

@Murias10 Murias10 Murias10 approved these changes

@carlosmndzg carlosmndzg carlosmndzg approved these changes

@Veneiro Veneiro Veneiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc05
6 participants
@didierrc @Veneiro @carlosmndzg @Murias10 @Raulms29 @IyanRobles