Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question translation #101

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Question translation #101

merged 6 commits into from
Mar 29, 2024

Conversation

carlosmndzg
Copy link
Contributor

Added attribute lang in endpoint /questions that returns the questions in the language provided. I also included basic tests for this functionality.

6bbffdc6d8311a4bb23ad19a0560e708

@carlosmndzg carlosmndzg requested a review from didierrc March 29, 2024 18:30
@carlosmndzg carlosmndzg self-assigned this Mar 29, 2024
didierrc
didierrc approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@didierrc didierrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good use of Microsoft API and thank you for adding tests to it!
Just remember to add the Github Secret of the required API Key to avoid data leaks.

@didierrc didierrc merged commit 0a0c21d into master Mar 29, 2024
1 check failed
@didierrc didierrc mentioned this pull request Apr 3, 2024
Closed
@didierrc didierrc deleted the question-translation branch April 3, 2024 17:45
@Raulms29 Raulms29 mentioned this pull request Apr 10, 2024
Closed
@carlosmndzg carlosmndzg mentioned this pull request Apr 10, 2024
Closed
@didierrc didierrc mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raulms29 Raulms29 Raulms29 approved these changes

@didierrc didierrc didierrc approved these changes

Assignees

@carlosmndzg carlosmndzg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosmndzg @didierrc @Raulms29