Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Questions and answers are now written in the DB! #97

Merged
merged 12 commits into from
Mar 9, 2024

Conversation

UO283615
Copy link
Contributor

@UO283615 UO283615 commented Mar 8, 2024

Now the questions are written in the DB, this is done by a new module.
Tests are yet to be done, but we wanted to upload this to have the application working with the wikidata questions.
We also need to write the architecturals decissions involved with this part.

@UO283615 UO283615 added the backend ⚙️ Backend issue label Mar 8, 2024
@UO283615 UO283615 added this to the Second delivery milestone Mar 8, 2024
@UO283615 UO283615 requested a review from GOLASOOO March 8, 2024 16:54
@UO283615 UO283615 self-assigned this Mar 8, 2024
@UO283615 UO283615 changed the base branch from master to develop March 8, 2024 17:39
@UO283615 UO283615 linked an issue Mar 8, 2024 that may be closed by this pull request
@GOLASOOO
Copy link
Contributor

GOLASOOO commented Mar 8, 2024

As we have discussed with @Toto-hitori, tests are meaningless as this code is just for DB connections and JPA models so they are discarded.
I think this code is fine for now, but in the future we may have problems with the current version of QuestionTemplate.call() in case we implement question types which require more than one query. We can start thinking about a solution for next versions but I would leave it as it is for now.

Copy link

sonarqubecloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Toto-hitori Toto-hitori merged commit f01d273 into develop Mar 9, 2024
2 checks passed
@Toto-hitori Toto-hitori deleted the feat/questionGeneratorMicroService branch March 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend ⚙️ Backend issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating the questions
3 participants