Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding the home page and tests for it #84

Merged
merged 3 commits into from
Mar 5, 2024
Merged

feat: Adding the home page and tests for it #84

merged 3 commits into from
Mar 5, 2024

Conversation

sergiorodriguezgarcia
Copy link
Contributor

New home funtionality and tests for it.

@sergiorodriguezgarcia sergiorodriguezgarcia added this to the Second delivery milestone Mar 5, 2024
@sergiorodriguezgarcia sergiorodriguezgarcia self-assigned this Mar 5, 2024
jjgancfer
jjgancfer requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We will probably have to revisit it later to redirect in case the user is already logged, but for now will do. Nevertheless, please localize the part marked.

webapp/src/pages/Root.jsx Outdated Show resolved Hide resolved
@sergiorodriguezgarcia
Copy link
Contributor Author

I think is a good approach, I will change and upload it.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

jjgancfer
jjgancfer approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the requested change was made, I'll approve the pull request.

gony02
gony02 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine, good job!!!

@gony02 gony02 merged commit de353cf into develop Mar 5, 2024
3 checks passed
@sergiorodriguezgarcia sergiorodriguezgarcia deleted the feat/webapp/new-home branch March 6, 2024 16:47
@sergiorodriguezgarcia sergiorodriguezgarcia mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjgancfer jjgancfer jjgancfer approved these changes

@gony02 gony02 gony02 approved these changes

Assignees

@sergiorodriguezgarcia sergiorodriguezgarcia

Labels
frontend 👁️ Frontend issue
Projects
None yet
Milestone
Second delivery
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiorodriguezgarcia @gony02 @jjgancfer