Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/webapp/new login #64

Merged
merged 20 commits into from
Mar 3, 2024
Merged

Feat/webapp/new login #64

merged 20 commits into from
Mar 3, 2024

Conversation

gony02
Copy link
Contributor

@gony02 gony02 commented Mar 1, 2024

Creating the login view with the corresponding tests and internationalisation. Two of the tests cannot pass.

Copy link
Contributor

@sergiorodriguezgarcia sergiorodriguezgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be correct.

@jjgancfer
Copy link
Contributor

I'm currently waiting for the bug in #69 to be solved, as I cannot work towards fixing the test that fails without it. I'll approve when it is.

webapp/src/pages/Login.jsx Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Mar 3, 2024

Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes seem to have been included. Approved.

@jjgancfer jjgancfer merged commit 91e4730 into develop Mar 3, 2024
2 checks passed
@Toto-hitori Toto-hitori deleted the feat/webapp/new-login branch March 3, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend 👁️ Frontend issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants