Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing some tables, plantuml diagrams and writing a title for … #54

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

gony02
Copy link
Contributor

@gony02 gony02 commented Feb 24, 2024

I have been making necessary changes to the documentation. I replaced png files with plantuml code. Additionally, I changed the title of the documentation to make it more personal. And lastly, I modified some tables.

@gony02 gony02 added the documentation 📜 Improvements or additions to documentation label Feb 24, 2024
@gony02 gony02 added this to the Second delivery milestone Feb 24, 2024
Copy link
Contributor

@Toto-hitori Toto-hitori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general quite good! I would appreciate if you could modify the glossary as well, because we had some feedback about not having to describe what React, SpringBoot and other technologies are and maybe we should describe what a Question, Answer or Game is instead

| Compatibility | The system must be compatible with various web browsers and devices, ensuring a seamless experience for users regardless of their choice of platform. It has to be well-optimized for different screen sizes and functionalities.
| Transferability | The system must allow for easy transfer of user data and game-related information through its APIs.
| Reliability | The system should be reliable in generating questions from Wikidata, ensuring that questions are accurate and diverse. The system shall handle user registrations, logins, and game data storage without errors.
| Availability | The system shall be available 99.99% of the time a user tries to access it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please lower this to 99%, 99.99% can only be achieved by huge companies and means only not having it available for 52 minutes in a year which may be too little?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with reducing the availability as I believe that it is too high.
About the glossary I think we can all discuss which terms should be defined.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with lowering the number; I think 99.99% is too big of a number (99% means an estimated downtime of a little above three days and a half). Also, consider mentioning this would be downtime not caused by the hosting service, as we do not have much control over that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also believe 99.99% is way too much for our capability. In my opinion 99% is a good goal for us.

Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see the requested changes in the comments of the @Toto-hitori's review.

Copy link

sonarqubecloud bot commented Mar 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes have been made. Approved.

@jjgancfer jjgancfer merged commit 5563bde into develop Mar 3, 2024
2 checks passed
@UO283615 UO283615 deleted the chore/documentation-fixes branch March 3, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📜 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants