Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/gonzalo a/docu #36

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Chore/gonzalo a/docu #36

merged 4 commits into from
Feb 18, 2024

Conversation

gony02
Copy link
Contributor

@gony02 gony02 commented Feb 15, 2024

This pull request contains the first version of this project documentation parts:

  1. Introduction and goals (1. Introduction and Goals #19)
  2. Quality requirements. (10. Quality Requirements #28)

I also added a new document called 13_annex.adoc with the complete functional requirements of the application.

@gony02 gony02 added the documentation 📜 Improvements or additions to documentation label Feb 15, 2024
@gony02 gony02 added this to the First delivery milestone Feb 15, 2024
@gony02 gony02 requested a review from jjgancfer February 15, 2024 10:56
@gony02 gony02 requested a review from Toto-hitori February 15, 2024 10:56
Copy link
Contributor

@Toto-hitori Toto-hitori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things have to be changed, I stopped commenting on the functional requirements since they need to be modified anyways. Fix what you seem fit. Apart from that great job!

docs/src/01_introduction_and_goals.adoc Outdated Show resolved Hide resolved
docs/src/01_introduction_and_goals.adoc Outdated Show resolved Hide resolved
docs/src/01_introduction_and_goals.adoc Outdated Show resolved Hide resolved
docs/src/01_introduction_and_goals.adoc Outdated Show resolved Hide resolved
docs/src/01_introduction_and_goals.adoc Show resolved Hide resolved
docs/src/10_quality_requirements.adoc Outdated Show resolved Hide resolved
docs/src/13_annex.adoc Show resolved Hide resolved
docs/src/13_annex.adoc Outdated Show resolved Hide resolved
docs/src/13_annex.adoc Outdated Show resolved Hide resolved
docs/src/13_annex.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, perform the requested changes or add context to the parts before re-submitting.

docs/src/13_annex.adoc Outdated Show resolved Hide resolved
docs/src/13_annex.adoc Outdated Show resolved Hide resolved
docs/src/13_annex.adoc Outdated Show resolved Hide resolved
… related to using "will" instead of "shall".
@gony02 gony02 force-pushed the chore/gonzaloA/docu branch from cb02550 to 8f35335 Compare February 16, 2024 17:21
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Toto-hitori Toto-hitori merged commit 26d1342 into develop Feb 18, 2024
2 checks passed
This was referenced Feb 18, 2024
@jjgancfer jjgancfer deleted the chore/gonzaloA/docu branch February 18, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📜 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants