Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added sections 2 and 8 to the documentation #31

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

UO283615
Copy link
Contributor

@UO283615 UO283615 commented Feb 9, 2024

This PR is about both sections, I think the second is good but the section 8 needs some discussion. Specifically because it includes a diagram about the domain model, which right now is a draft. I think we should discuss this on a meeting on tuesday, regardless, I think it would be nice to have some feedback here, so you can easily see the diagrama in this link.

I have not built the documentation for simplicity, so there might be some issues with the formatting, but I would prefer to have the data correct and format it later, as if everyone modifies the index.html at the same time it will make the PRs more tedious.

Written the first version of the section 2 of the documentation.
Written first draft of the section 8 of the documentation, the domain model is temporal.
@UO283615 UO283615 added the documentation 📜 Improvements or additions to documentation label Feb 9, 2024
@UO283615 UO283615 added this to the First delivery milestone Feb 9, 2024
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sergiorodriguezgarcia
Copy link
Contributor

I think that as a draft it is a good implementation, as we did not start to code and see the structure of the domain I believe that is a good first aproach. I also agree with you that would be a nice idea to debate about it in tuesday session.

@Toto-hitori
Copy link
Contributor

I think that as a draft it is a good implementation, as we did not start to code and see the structure of the domain I believe that is a good first aproach. I also agree with you that would be a nice idea to debate about it in tuesday session.

I agree with this, we should discuss on a specific solution on Tuesday's meeting

@sergiorodriguezgarcia sergiorodriguezgarcia merged commit cf2bf9e into develop Feb 14, 2024
2 checks passed
@jjgancfer jjgancfer deleted the chore/diego/docu branch February 14, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📜 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants