Trying to fix some build errors shown in the e2e tests of the build p…

…hase
Arquisoft · Apr 13, 2024 · f168984 · f168984
1 parent a8dd627
commit f168984
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/webapp/Dockerfile b/webapp/Dockerfile
@@ -14,5 +14,4 @@ RUN npm run build
 RUN npm install serve
 
 #Execute npm run prod to run the server
-CMD [ "npm", "run", "prod" ]
-#CMD ["npm", "start"]
+CMD [ "npm", "run", "prod" ]
diff --git a/webapp/src/components/HistoricalData/HistoricalView.js b/webapp/src/components/HistoricalData/HistoricalView.js
@@ -26,7 +26,7 @@ export default function HistoricalView() {
   useEffect(() => {getRecords()}, []);
   return (
     <div className='globalHistoricalView'>
-      {(records && records.length != 0) ? records.map((record, index) => (
+      {(records && records.length !== 0) ? records.map((record, index) => (
         <HistoricalGameElement key={index} record={record} t={t} />
       )): <p>{t("historicalView.no_games_played")}</p>}
     </div>

diff --git a/webapp/src/components/questionView/CreationHistoricalRecord.js b/webapp/src/components/questionView/CreationHistoricalRecord.js
@@ -11,7 +11,7 @@ class CreationHistoricalRecord{
     }
 
     addQuestion(statement, answers, answerGiven, correctAnswer, numQuestion) {
-        if(this.record.game.questions.length == numQuestion){
+        if(this.record.game.questions.length === numQuestion){
             this.record.game.questions.push({
                 question: statement,
                 answers: answers,

diff --git a/webapp/src/components/questionView/QuestionView.js b/webapp/src/components/questionView/QuestionView.js
@@ -62,7 +62,7 @@ function QuestionView(){
         });
     }
     function computePointsForQuestion(correctAnswer, answerGiven){
-        if(answerGiven==correctAnswer){
+        if(answerGiven===correctAnswer){
             points+=100;
         }else if(points-50>=0){
             points-=50;