feat: Add cancel button to playground runs #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can cancel runs with and without datasets. Cancellation is purely client-side. The backend should abort its tasks when connection with the client is lost.
cephalization
commented
Dec 2, 2024
|
|
||
| // Get the response as JSON | ||
| const json = await response.json(); | ||
| function fetchJsonObservable<T>( |
There was a problem hiding this comment.
I could not find any examples of how to trigger an abort controller from a relay disposable.
Had to whip this up, surprised it works 😂
There was a problem hiding this comment.
People have been asking for this since 2018 apparently
dosubot
bot
added
the
size:L
Comment on lines
+22
to
+39
| icon={ | ||
| !isRunning ? ( | ||
| <Icon svg={<Icons.PlayCircleOutline />} /> | ||
| ) : ( | ||
| <div | ||
| css={css` | ||
| margin-right: var(--ac-global-dimension-static-size-50); | ||
| & > * { | ||
| height: 1em; | ||
| width: 1em; | ||
| font-size: 1.3rem; | ||
| } | ||
| `} | ||
| > | ||
| <Loading size="S" /> | ||
| </div> | ||
| ) | ||
| } |
There was a problem hiding this comment.
we have a loading prop on our buttons you can use instead of this i think
There was a problem hiding this comment.
It also disables the button, so I can't use it
There was a problem hiding this comment.
ahh okay, this works then
Parker-Stafford
approved these changes
Dec 2, 2024
|
can we get an issue to track server side cancel support? |
|
See #5573 for backend work |
cephalization
deleted the
cephalization/5484-playground-run-cancel-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can cancel runs with and without datasets.
- [ ] Server side run cancellationwill do this in future workCancel.prompts.mov
Cancel.Datasets.mov
resolves: #5484