Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auth): strengthen check constraints related to auth method #4704

Merged
merged 5 commits into from
Sep 20, 2024
Merged

chore(auth): strengthen check constraints related to auth method #4704

merged 5 commits into from
Sep 20, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Sep 20, 2024 •
edited
Loading

strengthens check constraints related to auth methods

  • password_hash and password_salt must be set or unset together
  • oauth2_client_id and oauth2_user_id must be set or unset together
  • a single user can have at most one auth method

resolves #4688

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 20, 2024
@axiomofjoy axiomofjoy changed the base branch from main to xander/oauth-orm-improvements September 20, 2024 20:11
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Sep 20, 2024
@axiomofjoy axiomofjoy marked this pull request as draft September 20, 2024 20:25
@axiomofjoy axiomofjoy marked this pull request as ready for review September 20, 2024 20:35
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 20, 2024
@axiomofjoy axiomofjoy force-pushed the xander/oauth-orm-improvements branch from db5c30e to 71525dc Compare September 20, 2024 21:56
@axiomofjoy axiomofjoy force-pushed the xander/auth-check-constraints branch from af5292d to e85089c Compare September 20, 2024 21:59
Base automatically changed from xander/oauth-orm-improvements to auth September 20, 2024 23:34
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 20, 2024
@axiomofjoy axiomofjoy merged commit 2548a79 into auth Sep 20, 2024
13 checks passed
@axiomofjoy axiomofjoy deleted the xander/auth-check-constraints branch September 20, 2024 23:34
RogerHYang pushed a commit that referenced this pull request Sep 21, 2024
@axiomofjoy @RogerHYang
chore(auth): strengthen check constraints related to auth method (#4704)
afe991c
This was referenced Sep 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerHYang RogerHYang RogerHYang approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[auth][oauth] add check constraint between local and oauth fields on users table
2 participants
@axiomofjoy @RogerHYang