Merge pull request fedimint#6445 from elsirion/2024-11-efficient-op-log

fix: use linear pagination algorithm for operation log
AreaLayer · Dec 2, 2024 · c319879 · c319879
2 parents 33cc642 + 07a3092
commit c319879
Show file tree

Hide file tree

Showing 6 changed files with 314 additions and 58 deletions.
diff --git a/fedimint-cli/src/client.rs b/fedimint-cli/src/client.rs
@@ -532,7 +532,7 @@ pub async fn handle_command(
 
             let operations = client
                 .operation_log()
-                .list_operations(limit, None)
+                .paginate_operations_rev(limit, None)
                 .await
                 .into_iter()
                 .map(|(k, v)| {

diff --git a/fedimint-client/src/db.rs b/fedimint-client/src/db.rs
@@ -122,7 +122,7 @@ impl_db_record!(
 );
 
 /// Key used to lookup operation log entries in chronological order
-#[derive(Debug, Clone, Copy, Encodable, Decodable, Serialize)]
+#[derive(Debug, Clone, Copy, Hash, Eq, PartialEq, Encodable, Decodable, Serialize)]
 pub struct ChronologicalOperationLogKey {
     pub creation_time: std::time::SystemTime,
     pub operation_id: OperationId,

diff --git a/fedimint-client/src/lib.rs b/fedimint-client/src/lib.rs
@@ -2128,7 +2128,7 @@ impl Client {
                 }
                 "list_operations" => {
                     // TODO: support pagination
-                    let operations = self.operation_log().list_operations(usize::MAX, None).await;
+                    let operations = self.operation_log().paginate_operations_rev(usize::MAX, None).await;
                     yield serde_json::to_value(operations)?;
                 }
                 "has_pending_recoveries" => {