More Idiomatic Use of CMake #164
Conversation
This commit makes sure that pthreads will be linked by CMake in the idiomatic way (sse https://stackoverflow.com/a/29871891 as reference). Also the linking options won't be set via CXX flags because this caused lead to weird effects on some Linux distros (undefined reference to `hci_get_route' on my system). See the CMake documenation: https://cmake.org/cmake/help/latest/command/target_link_libraries.html Finally, this commit also makes sure that build artifacts won't show up in Git commands in the idiomatic way.
|
CMake Error at CMakeLists.txt:92 (target_link_libraries): cmake version 3.18.4 (I'm on Ubuntu 18.04 as this is my target system for serveral Docker systems including ROS for Sunray) |
|
@greymfm, that is a bummer… Is the reliance on such an old distro related to the fact that the Bananapi M4 has no compatible, up to date kernel verions? If this is the case, is there a way to support something like armbian/build#7158 from your end? |
|
No, Sunray can be compiled as ROS node (https://github.com/Ardumower/Sunray?tab=readme-ov-file#sunray_ros and https://www.ros.org/), and ROS (with a full robotics LiDAR driver and LiDAR localization ecosystem) and those drivers and localization packages are often compiled for ROS Melodic (they are working on newer ROS versions but it will take time...) - and ROS Melodic only runs on Ubuntu 18.04 - and because of that we use Docker :-) |
|
Not sure if I can follow you because I'm not familiar with ROS. Just digged into the space of ROS a bit and it seems that ROS Melodic is out of maintenance and one should switch to ROS 2 Jazzy Jalisco. What is blocking you to switch to this more recent version? Is it the Livox SDK not being compatible? For Livox-SDK/Livox-SDK2#76 there is already a fix available which you could test: Livox-SDK/Livox-SDK2#85 |
This commit makes sure that pthreads will be linked by CMake in the idiomatic way (sse https://stackoverflow.com/a/29871891 as reference). Also the linking options won't be set via CXX flags because this caused lead to weird effects on some Linux distros (undefined reference to `hci_get_route' on my system). See the CMake documenation: https://cmake.org/cmake/help/latest/command/target_link_libraries.html
Finally, this commit also makes sure that build artifacts won't show up in Git commands in the idiomatic way.
FYI: Issues discovered in #163