Update warning fix from upstream #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r unitests on OSX. Problem: It's really hard to get Libuavcan tests building on a mac or other platform if googletest isn't installed. Solution: add "if linux" guards to problem areas. Also include googletest as recommended in the googletest project's README. Testing: Successfully built on OSX sierra using gcc6
Problem: There is no automated way to setup a build environment. Solution: Use Vagrant to pull an Ubuntu image and install the same prerequisites used on Travis. Testing: Full build on my macintosh.
Problem: auto_ptr is deprecated. Solution: use unique_ptr which is only available in c++11 and newer. Also fix how unit tests are run as part of the build to keep them from being deleted when they fail. Testing: Unit tests on linux run.
Just going to merge this. No risk the larger project here.
|
doesn't change build on CubeOrange but fix remove some warning on static analyzer, so it is good !: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This get some Warning Fixs PR from upstream and allow to build in CPP11