AnalyticTune: select axis and time period more accurately #225
Conversation
| const msg = MSG.Message[i] | ||
|
|
||
| // narrow the SID time window | ||
| if (msg === 'SystemID Finished') { |
There was a problem hiding this comment.
Could we not looks at the last time stamp of the SIDD data? Looking for messages is quite fragile.
There was a problem hiding this comment.
Unfortunately not because once started the data is being logged until you land. Obviously we could change sysid (and I think we should) but that doesn't help right now
There was a problem hiding this comment.
I don’t think that is true. SIDD is only logged when the Sysid mode is active.
There was a problem hiding this comment.
You’d be better off using the time parameter that specifies the length of the chirp and ending it after the chirp ends
There was a problem hiding this comment.
That is true, but that's not the same thing as SID running. Typically once started I leave it running until I land even though the sweep has long finished
There was a problem hiding this comment.
Well if you use the parameter for the length of the chirp in the webtool to determine the end of the data then that should work.
|
@andyp1per @IamPete1 I have incorporated this feature in PR #227. You can close this if that PR meets your approval |
Just a couple of usability tweaks