Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSPP] Alconna V2 - Sistana #91

Merged
merged 130 commits into from
Oct 12, 2024
Merged

[OSPP] Alconna V2 - Sistana #91

merged 130 commits into from
Oct 12, 2024

Conversation

GreyElaina
Copy link
Contributor

@GreyElaina GreyElaina commented Sep 20, 2024 •
edited by RF-Tar-Railt
Loading

resolve #88

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Sep 20, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Sep 20, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@GreyElaina GreyElaina changed the title sistana: migrate from local lab [OSPP] Alconna V2 Sep 20, 2024
@GreyElaina GreyElaina marked this pull request as draft September 20, 2024 10:11
@GreyElaina
Copy link
Contributor Author

敬请见证：https://wakatime.com/@9b922d20-ae54-4b73-81de-c31145268b46

@GreyElaina
sistana: new receiver, endpoint determine
9cdfd3b
@GreyElaina
sistana: feat: ConstraintRx
b29f17c
@GreyElaina
sistana: fix: push ahead with Value.value
b2989b1
@GreyElaina
sistana: free required snapshot from track
d814a65
@GreyElaina
sistana: feat: complete_on_determined
03ea5b7
@GreyElaina
sistana: feat: support option traverse
9df5df7
@GreyElaina
sistana: fix: apply default with Value.value
bcdacf3
@GreyElaina
sistana: feat: spec
0e61841 
ial rx behavior
@GreyElaina
sistana: fix: always set value now
08dcfb2
@GreyElaina
sistana: remove SubcommandTraverse.satisfied
61f3cc3
@GreyElaina
sistana: feat: IndexedOptionTraversesRecord counts by keyword
1f98b3f
@GreyElaina
sistana: feat: Buffer.pushleft
ff2d4fb
@GreyElaina
sistana: Buffer.pushleft reject empty segment
8b4dedc
@GreyElaina
sistana: feat: option traverse works
c46e2dd
@GreyElaina
sistana: analyzer returns description only
1f29371
@GreyElaina
sistana: some tiny changes
5061710
@GreyElaina
sistana: fix: append -> appendleft
e93628f
@GreyElaina
sistana: feat: Fragment.{separators, hybrid_separators}
b88d3d1
@GreyElaina
sistana: clean done todo
08907c0
@GreyElaina
sistana: feat: record subcommmand trigger in traverse
d000dc4
@GreyElaina
sistana: feat: Fragment.apply_nepattern(capture_mode: bool)
da65981
@GreyElaina
Merge branch 'ArcletProject:dev' into v2-sistana
98f8413
@GreyElaina
legecy: merge arclet.alconna.model pyi
d125b55
@GreyElaina
sistana: move type, cast attr to userspace
cc22687
@GreyElaina
sistana: drop triehard, implement compact
0f549d4
@GreyElaina
sistana: use cached trigger
63ed61b
@GreyElaina
sistana: remove unused import
532d04f
@GreyElaina
sistana: fix option trigger
da71338
@GreyElaina
test: sistana
425ed4d
@GreyElaina
sistana: fix: fragments order check
2062d09
@GreyElaina
sistana: fix non-consist naming
ee3b3f5
@GreyElaina
sistana: fix wrong exit reason
dcec943
@GreyElaina
sistana: fix determined instant exit
a1e5756
@GreyElaina
sistana: add tests
ce2567b
@GreyElaina
sistana: remove unused args
7d9d423
@GreyElaina
sistana: remove unused protected helper method
c47c678
@GreyElaina
sistana: fix satisfied check
c064017
@GreyElaina
sistana: fix header edge case
7ab5e5d
@GreyElaina
Refactor test_analyze.py and test_pattern.py
2247411 
- Remove unused protected helper method in test_analyze.py
- Remove unused args in test_analyze.py
- Add tests for header separator and stage unsatisfied in test_analyze.py
- Add tests for header edge case and variadic in test_mix.py
- Add tests for aliases and add_option in test_pattern.py
- Add tests for AccumRx, CountRx, and ConstRx in test_receiver.py
@GreyElaina
sistana: basically acceptable
a25ca9d
@GreyElaina GreyElaina marked this pull request as ready for review October 9, 2024 13:34
sourcery-ai[bot]
sourcery-ai bot reviewed Oct 9, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@RF-Tar-Railt RF-Tar-Railt changed the title [OSPP] Alconna V2 [OSPP] Alconna V2 - Sistina Oct 9, 2024
@GreyElaina GreyElaina changed the title [OSPP] Alconna V2 - Sistina [OSPP] Alconna V2 - Sistana Oct 9, 2024
RF-Tar-Railt
RF-Tar-Railt requested changes Oct 10, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
src/arclet/alconna/sistana/fragment.py Outdated Show resolved Hide resolved
@RF-Tar-Railt RF-Tar-Railt merged commit 5e03cf6 into ArcletProject:dev Oct 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@RF-Tar-Railt RF-Tar-Railt RF-Tar-Railt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OSPP] Alconna 2.0 版本设计与开发
2 participants
@GreyElaina @RF-Tar-Railt