Stardew Valley: Remove seasonal farming event, use regions instead #4379
+9
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: refactor/cleanup
agilbert1412
approved these changes
Dec 16, 2024
Jouramie
added a commit
to agilbert1412/Archipelago
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This removes the event that were used in logic for crops. I realized while working on #4378 that they're just unneeded because we can use the region.
Stardew has no entrance that require crops, so this has no impact on indirect connection. Even if there was, the rule framework automatically registers them so it would not be an issue.
No real impact on performance.
How was this tested?
Unit tests, plus made sure that the rule is removed with the explain command.
Before, with the event
Now, without the event
If this makes graphical changes, please attach screenshots.
N/A