SMZ3: Fix minimal logic considering SM boss tokens unnecessary #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
is: bug/fix
|
This comment is now outdated and should be removed to avoid confusion: Archipelago/worlds/smz3/__init__.py Line 233 in 728d249 |
|
Removing the comment is likely to cause more confusion ("why isn't SM mentioned at all in the completion condition, only Z3 is"); a minor rewording to reflect the current behavior should suffice. |
|
I think the release blocker tag would be appropriate, since a seed can be impossible to win. |
Exempt-Medic
added
the
affects: release/blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
SMZ3 used to rely on the fact that entering GT logically required all SM boss tokens as part of its victory condition, but SMZ3 version 11.3 actually changed that logic so that the number of required SM boss tokens to logically enter GT scales with its crystal entry cost. This means that some boss tokens were being considered unnecessary for game completion, which means minimal accessibility wouldn't ensure that the correct number of boss tokens could actually be reached, resulting in an impossible seed sometimes being generated. (Well, as "impossible" as anything is in LTTP, anyway.)
How was this tested?
Test generations with 0/7/4 minimal accessibility seeds.