Stardew Valley: Move filler pool generation out of the world class #4372
+45
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: refactor/cleanup
agilbert1412
approved these changes
Dec 14, 2024
Jouramie
added a commit
to agilbert1412/Archipelago
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This adds more cohesion in the handling of group fillers by first updating their options so it can reuse the same filler stuff as normal worlds.
How was this tested?
Ran the tests, specifically
TestItemLink.pywhich exactly verify that the correct items are disabled depending on the options.If this makes graphical changes, please attach screenshots.
N/A