Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUNIC: Logic for bushes in guard house 2 upper and belltower #4371

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ScipioWright
Copy link
Collaborator

@ScipioWright ScipioWright commented Dec 14, 2024

What is this fixing or adding?

I <3 bushes
Adds logic for breaking the bushes in guard house 2 upper. Only relevant with ladder shuffle or ER or whatever else uses the ER rules on.
Also forest belltower.

How was this tested?

Test gens.

@ScipioWright ScipioWright added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: author Issue/PR is waiting for feedback or changes from its author. labels Dec 14, 2024
@ScipioWright ScipioWright removed the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Dec 14, 2024
@ScipioWright ScipioWright changed the title TUNIC: Logic for bushes in guard house 2 upper TUNIC: Logic for bushes in guard house 2 upper and belltower Dec 14, 2024
worlds/tunic/er_rules.py Outdated Show resolved Hide resolved
Copy link

@roseasromeo roseasromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added logic is in line with how the rando functions, new regions prevent soft-locking due to lack of access to bush-cutting.

@Seatori
Copy link
Contributor

Seatori commented Dec 15, 2024

Tested in-game and verified that all of the listed methods were valid ways of reaching each entrance.
Also ran several test generations using plando to verify that each method was correctly registered, and viewed playthroughs in which each method was in play.
Lastly, I verified that the easy ice grappling method wasn't expected with ice grappling disabled by using plando to create an impossible seed without using Magic Orb + Magic Dagger on that entrance, seeing that it failed with ice grappling disabled, and that it succeeded when it was enabled on all three difficulty levels.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Dec 15, 2024
@Berserker66 Berserker66 added waiting-on: author Issue/PR is waiting for feedback or changes from its author. and removed waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. labels Dec 15, 2024
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: author Issue/PR is waiting for feedback or changes from its author. labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants