Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiServer: Revert hints being created for already found locations #4367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Dec 12, 2024

Reverts #4214
I merged that PR believing it merely fixed an issue with LocationScouts, but it also caused all hints being saved & thrown into the hints tab, even the 100 already found Power Stars when you hint your 101st.

To address the issue that 4214 fixed (which would be reverted into being broken again), there is this companion PR: #4368

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Dec 12, 2024
@NewSoupVi NewSoupVi added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: release/blocker Issues/PRs that must be addressed before next official release. labels Dec 12, 2024
@NewSoupVi
Copy link
Member Author

NewSoupVi commented Dec 12, 2024

I believe we need to make a decision on this before the next version can release, hence the affects: release/blocker.

@qwint
Copy link
Contributor

qwint commented Dec 12, 2024

to put my 2 cents here for visibility
the usecase that seems to be the biggest problem is

  • user is sent 1st copy of Item
  • user !hint item
  • the previously found copy of Item is persisted to hints and thus displayed in text client hint tab etc.

(obviously exacerbated by mcguffin hunts with 100s of copies)
in my opinion instead of making it so all found hints don't get persisted there should be a separate codepath that smartly understands which copies the user actually intended to ask about (i.e. when hinting an item/location group or item with multiple copies, don't consider the found instances for hinting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants