Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorio: Fix for uranium-mining not marked as progression #4357

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CaitSith2
Copy link
Member

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

Uranium-mining marked as progression when any uranium based ingredients are present in science packs, rocket silo, rocket part, or satellite recipe.

How was this tested?

Generated games where uranium sources ended up in science packs or rocket related items.

If this makes graphical changes, please attach screenshots.

@CaitSith2 CaitSith2 added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: release/blocker Issues/PRs that must be addressed before next official release. labels Dec 10, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Dec 10, 2024
@Berserker66
Copy link
Member

This should be done through the extractor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants