BizhawkClient: set metadata from patch file #4346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Patch.create_rom_filereturns a metadata object such that rom clients can immediately connect to the room tied to the patch file should one exist (ie WebHost). BizhawkClient currently just discards this metadata without properly setting it, so we return the metadata and properly setargs.connectfrom it.How was this tested?
Hosted a room with MM2 and downloaded the patch file. Patched the file and watched as BizhawkClient was able to connect to the room by itself.
If this makes graphical changes, please attach screenshots.