Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landstalker: Fix issues on generation #4345

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dinopony
Copy link
Collaborator

@Dinopony Dinopony commented Dec 8, 2024

What is this fixing or adding?

This bundles a few fixes for Landstalker world generation:

How was this tested?

This was tested by manually generating ~100 seeds with the previously problematic options set to ensure it was fixed.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Dec 8, 2024
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Dec 8, 2024
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Did not test gen.
I think plando might mess with the jewel hints since plando from_pool currently removes the existing item and creates a new item to replace it, so I would recommend looking into that (not in this PR of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants