Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: make get_filler_item_name abstract #4341

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

Makes the get_filler_item_name implementation an abstract method, forcing worlds to implement it. Provides a default implementation that can be used if desired.

How was this tested?

Generated successfully with factorio. Tests all fail for worlds that can't be created with this.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Dec 8, 2024
@NewSoupVi
Copy link
Member

Factorio is tough but Raft definitely has plenty of filler items it can generate. I might have a look at it and open the PR myself

@alwaysintreble
Copy link
Collaborator Author

@alwaysintreble
Copy link
Collaborator Author

Thought I recalled sunnybat saying they wanted default but seems I misremembered so I'll drop that one

@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants