HK: abstract and default grub counts #4336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
reviewed
Dec 7, 2024
worlds/hk/__init__.py
Outdated
|
|
||
| # defaulting so completion condition isn't incorrect before pre_fill | ||
| self.grub_count = 46 | ||
| self.grub_player_count = {player: 46} |
There was a problem hiding this comment.
Mentioned in DM's, but you probably want to set this based on the required grub count
Exempt-Medic
requested changes
Dec 7, 2024
There was a problem hiding this comment.
One comment about always requiring 46 Grubs, but otherwise the code LGTM. I honestly love this a lot more than the previous code. Tested using a minimal accessibility yaml with plando'ed inaccessible Grub on an "All" Grubs win condition and saw that it would now fail properly (during plando).
Exempt-Medic
approved these changes
Dec 7, 2024
Exempt-Medic
added
the
is: bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Medic had some usecase where the grub goal not being set before pre_fill caused issues
How was this tested?
ran the grub tests i wrote before to make sure nothing changed, did not test the goal between set_rules and pre_fill
If this makes graphical changes, please attach screenshots.