Super Mario 64: ItemData class and tables

[josephwhite]

What is this fixing or adding?

Adds an ItemData class to include ItemClassification in the item tables, similar to other worlds.

• Simplifies create_item.
• Utilize base id when assigning IDs.

How was this tested?

• Several seed generations.
  • Item ID range
  • Move rando
• Ran Webhost.py and generated a YAML (MoveRandomizerActions in Options.py).
• Repo wide unit tests

[Exempt-Medic]

Should be able to just use dict since 3.8/3.9 was dropped

[Exempt-Medic]

Can do this now too (and remove the Optional import)

Suggested change

	code: Optional[int] = None
	code: int | None = None

[Exempt-Medic]

Might as well add the EoF newline now

Suggested change

	item_table = {name: data.code for name, data in item_data_table.items() if data.code is not None}
	item_table = {name: data.code for name, data in item_data_table.items() if data.code is not None}

[Exempt-Medic]

It's probably fine to add them, but just letting you know that item_descriptions don't currently do anything

[josephwhite]

It's probably fine to add them, but just letting you know that item_descriptions don't currently do anything

Did I mess up the implementation or did item descriptions brake between #2409/#2508 and now?
I tried to follow the World API and Dark Souls III implementation and didn't see any GitHub issues regarding it.

[Exempt-Medic]

Did I mess up the implementation or did item descriptions brake between #2409/#2508 and now? I tried to follow the World API and Dark Souls III implementation and didn't see any GitHub issues regarding it.

When the options system was overhauled, their functionality was removed. DS3 still has them, they just don't do anything. I believe you added them correctly

[N00byKing]

Sorry, but I don't think I'm in favor of this change. It seems to introduce a lot of redundancy for very little benefit, if at all.
Adding the item classification into the table just means that there's now another field that has to be filled in.
The existing solution with the if-else looks ugly, but to me preferable than giving the classification explicitly for every item.

[josephwhite]

The existing solution with the if-else looks ugly, but to me preferable than giving the classification explicitly for every item.

Explicitly stating classification for each item doesn't have to be necessary if the same if-else logic is ported to the item tables where the default classification of items is progressive. Code has been updated to show this change if verbosity was the main downside of this change.

When the options system was overhauled, [item descriptions] functionality was removed. DS3 still has them, they just don't do anything. I believe you added them correctly.

💀. Removed.