UpdateHint: create_if_not_exists (Allows clients to hint own items in other worlds)

[NewSoupVi]

Basically, this is supposed to "supercede" #3523, and the concept of LocationScouts with create_as_hint in general.

I'm not sure if this should be its own new command called CreateHint instead.
If it were its own command, we could let the client provide a list of locations like with LocationScouts.
However, we would also have to maintain some stuff in two places. In my estimation, anything that you specify when creating a hint is also something you'd want to be able to update.

Lmk what you think.

[NewSoupVi]

On #3523, and also just from many interactions with users and world devs who have in-game hints, I can confidently say that this is a highly requested feature. I'm hoping we can make it happen this time.

[EmilyV99]

LGTM, read through all the code.

[Jarno458]

I would really like the ability of creating hints in bulk (like an array of locations to create hints for)
this is often useful for opening shops and sending hints for everything the player knows at that point

Also this way of creating hints through updates does not allow to silently create hint or to not broadcast hints a 2nd time, like scout locations has

[NewSoupVi]

does not allow to silently create hint

LocationScouts does not allow this either. create_as_hint = 0 will just send back the location info and not create a hint at all.

or to not broadcast hints a 2nd time

That is how this PR works, though. This PR will only create & broadcast the hint if it doesn't already exist.
The functionality that is removed in this PR is to rebroadcast hints over and over.

The list thing is fair though. I might separate it out into its own command for that reason, more opinions welcome

[Jarno458]

i would remove already from this scentence

[Jarno458]

for items for other players is a bit odd, as its items send by other players. not items for those other players

[Jarno458]

No Permission Might be on purpose but this gives no information on why your getting this response, and if its as part of an implementation error by the client, then it might not help the dev to understand what went wrong

[Jarno458]

I would move the try/catch for status = HintStatus(status_int) above the hint = ctx.get_hint(client.team, location_player, location) as it breaks the flow that there is a check for if hint is None right below it

[NewSoupVi]

Decided to go with a new command instead.

#4317