Core: Fix crash when trying to log an exception

[NewSoupVi]

In #3028, we added a new logging filter which checked record.msg.

However, you can pass whatever you want into a logging call. In this case, what we missed was https://github.com/ArchipelagoMW/Archipelago/blob/ecc3094c70b3ee1f3e18d9299c03198564ec261a/MultiServer.py#L530C1-L530C37, where we pass an Exception object as the message. This currently causes a crash with the new filter.

As far as I can tell, the logging module supports this. It has no typing and can handle passing objects as messages just fine, it just converts them to a string.

What you're supposed to use, as far as I understand it, is record.getMessage() instead of record.msg, which is guaranteed to be a string that represents what the final message will actually be.

[NewSoupVi]

If this isn't just merged by a different core maintainer without peer review (prayge), then @kedNalatacId would like your peer review on this if you have a minute to look at it

[black-sliver]

@Berserker66 you think that could've crashed MultiHoster11 ?
No, _save is the impl that does not run on WebHost.
This should not be in active_webhost (see Vi's comment below)

A similar line exists in customserver here:

Archipelago/WebHostLib/customserver.py

Line 303 in ecc3094

logger.exception(e)

[NewSoupVi]

The PR that added this was merged two days ago

[kedNalatacId]

If this isn't just merged by a different core maintainer without peer review (prayge), then @kedNalatacId would like your peer review on this if you have a minute to look at it

looks good to me; sorry for missing this use case.