Stardew Valley: Fix a bug where walnutsanity would get deactivated even tho ginger island got forced activated (and move some files) #4311
Conversation
github-actions
bot
added
the
waiting-on: peer-review
Jouramie
changed the title
agilbert1412
added
is: bug/fix
| try: | ||
| from Options import OptionGroup | ||
| except ImportError: | ||
| logging.warning("Old AP Version, OptionGroup not available.") |
There was a problem hiding this comment.
Probably not, but I would rather not change too much the content of this file, since it was only supported to be moved.
| @@ -112,36 +113,9 @@ def interpret_slot_data(self, slot_data: Dict[str, Any]) -> Optional[int]: | |||
| return seed | |||
|
|
|||
| def generate_early(self): | |||
| self.force_change_options_if_incompatible() | |||
| force_change_options_if_incompatible(self.options, self.player, self.player_name) | |||
There was a problem hiding this comment.
Is there a reason this doesn't just pass the world and you grab the options, player, and name off that?
There was a problem hiding this comment.
It makes it easier to test specifically that options were changed without creating a complete world. We've often been rightfully criticized for generating too many worlds just to test small things that could be unit tested, so I'm slowly trying to address that.
There was a problem hiding this comment.
Overall it seems fine. Tested some generations to see the new warnings. Did not look at any of the test changes (don't really see why I would). Checked the file refactoring through text comparisons and before/after were the same aside from things like options. being removed. Had some comments on the changes (see above), but it's mostly fine. Honestly, I'm surprised world_options.walnutsanity != options.Walnutsanity.preset_none works the way it does, but it seems to so that's good.
agilbert1412
added
waiting-on: core-review
|
What is this fixing or adding?
🙄
This fixes a bug with the options force activation where ginger island would get activated because of a ginger island goal, but walnutsanity would get deactivated right after. This happens because the
exclude_ginger_islandvariable was not refreshed after ginger island got activated.This branch also contains a bunch of moved files to regroup option related stuff in their own module. If you want to review specifically the fix, it is in this commit: af14bcb
How was this tested?
If this makes graphical changes, please attach screenshots.
N/A