Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Multiserver: Properly handle Disabled Hints #4307

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PoryGone
Copy link
Collaborator

What is this fixing or adding?

  • Be more explicit with the player about when hints are disabled.
    • I've seen multiple cases of players setting Hint Cost to "Off` using the website, then being confused why their hints cost 105%
  • Additionally, block LocationScouts from creating as hints if hints are disabled.
    • This was a feature discussed by several people as very desirable when I first started writing this feature a year ago. Unfortunately, those conversations are lost to time

How was this tested?

TBD

If this makes graphical changes, please attach screenshots.

TBD

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Nov 30, 2024
@Exempt-Medic
Copy link
Member

Just pointing out that this changes the behavior for hint costs between 100 and 199 when dealing with worlds with less than 100 locations. I would probably call it a bugfix, but it is a change nonetheless

@PoryGone
Copy link
Collaborator Author

Just pointing out that this changes the behavior for hint costs between 100 and 199 when dealing with worlds with less than 100 locations. I would probably call it a bugfix, but it is a change nonetheless

The Webhost only specifically supplies values up to 105% (which it aliases as "Off"). I've not encountered any discussion of use cases for specific values >100, so I'm not even sure what effect costs between 100 and 199 would even have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants