Docs: add description of Indirect Condition problem #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrote up a big effortpost about indirect conditions for nex on the [DS3 3.0 PR](ArchipelagoMW#3128 (comment)). The version I'm [PRing to the world API document](ArchipelagoMW#3552) is very brief and unnuanced, because I'd rather people use too many indirect conditions than too few. But that might leave some devs wanting to know more. I think that comment on nex's DS3 PR is probably the best detailed explanation for indirect conditions that exists currently. So I think it's good if it exists somewhere. And the FAQ doc seems like the best place right now, because I don't want to write an entirely new doc at the moment.
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Scipio Wright <[email protected]>
Co-authored-by: Scipio Wright <[email protected]>
Co-authored-by: qwint <[email protected]>
Co-authored-by: qwint <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: qwint <[email protected]>
Co-authored-by: qwint <[email protected]>
…ion section to apworld dev faq doc
github-actions
bot
added
is: documentation
|
LGTM. This explains well the situation, why they are needed, how to opt-out and the drawbacks from opting out. |
Jouramie
approved these changes
Nov 30, 2024
ScipioWright
suggested changes
Dec 5, 2024
Co-authored-by: Scipio Wright <[email protected]>
Co-authored-by: Scipio Wright <[email protected]>
Co-authored-by: Scipio Wright <[email protected]>
qwint
commented
Dec 6, 2024
Co-authored-by: Scipio Wright <[email protected]>
ScipioWright
approved these changes
Dec 12, 2024
ScipioWright
added
waiting-on: core-review
black-sliver
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
fix the last couple of wording issues I have with #3698
opened as a unique PR per permission from VI
How was this tested?
eyeballs
If this makes graphical changes, please attach screenshots.