Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: log process ID #4290

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Core: log process ID #4290

merged 1 commit into from
Dec 3, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

logs process ID in cases where it might matter.

How was this tested?

[2024-11-29 23:18:30] Archipelago (0.6.0) logging initialized on Windows-10-10.0.19045-SP0 process 20648 running Python 3.12.6

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 29, 2024
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see this being potentially useful, LGTM

@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Nov 30, 2024
@Berserker66 Berserker66 merged commit ffe0221 into main Dec 3, 2024
26 checks passed
@Berserker66 Berserker66 deleted the core_log_process_id branch December 3, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants