Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launcher: launch without delay on URI without choice #4279

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Launcher: launch without delay on URI without choice #4279

merged 1 commit into from
Dec 1, 2024

Conversation

Berserker66
Copy link
Member

@Berserker66 Berserker66 commented Nov 28, 2024 •
edited
Loading

What is this fixing or adding?

When handling a uri to launch it now instantly launches Text Client if nothing else is registered

How was this tested?

I only tested Launcher.py archipelago://localhost

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 28, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Nov 28, 2024
BadMagic100
BadMagic100 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@BadMagic100 BadMagic100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned kivy just to review this pr

My approving review is only to say that from a UX perspective I believe this is a substantial improvement, and the code looks remotely reasonable. No clue if it works

qwint
qwint approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is reasonable, tested a couple URIs to confirm functionality is as expected

on the UX design personally I don't care either way

@Berserker66 Berserker66 added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 30, 2024
@NewSoupVi
Copy link
Member

I was on board with the countdown but it seems like everyone else really isn't, and this is simpler anyway, so

@Berserker66 Berserker66 merged commit ecc3094 into main Dec 1, 2024
26 checks passed
@Berserker66 Berserker66 deleted the launcher_no_delay_launch branch December 1, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@BadMagic100 BadMagic100 BadMagic100 approved these changes

@qwint qwint qwint approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Berserker66 @NewSoupVi @qwint @BadMagic100 @Exempt-Medic