Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLC Quest Bug Fix 50+ coin bundle basic Campaign #4276

Merged

Conversation

axe-y
Copy link
Collaborator

@axe-y axe-y commented Nov 28, 2024

Fixing a generation bug

What is this fixing or adding?

if you are playing either both or basic campaign and you have coinsanity above 50 and you are alone in the multiworld the generation crash

How was this tested?

unit test and some game generation that failed before

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 28, 2024
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Nov 28, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Tested various configurations of campaign, coinsanity, and bundle size and all generations were now successful

@NewSoupVi NewSoupVi merged commit 283d1ab into ArchipelagoMW:main Nov 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants