Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: Fix crash on advanced options when a Range option uses "random" as its default #4263

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Nov 27, 2024

This whole code looks a bit jank to me, but I don't think I'm capable of improving it.
Anyway, this problem means that you currently cannot access https://archipelago.gg/games/The%20Witness/weighted-options

Tested: Mostly just checked whether it works after

@github-actions github-actions bot added affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 27, 2024
@NewSoupVi NewSoupVi added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Nov 27, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested localhost and the advanced option page now loads and can generate properly. I won't pretend I understand what the code here was doing or was for but this seems to fix it

@NewSoupVi NewSoupVi merged commit e1f16c6 into main Nov 27, 2024
17 checks passed
Berserker66 pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants