Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HK: Fix Nondeterministic Behavior #4244

Merged
merged 1 commit into from
Nov 25, 2024
Merged

HK: Fix Nondeterministic Behavior #4244

merged 1 commit into from
Nov 25, 2024

Conversation

Exempt-Medic
Copy link
Member

@Exempt-Medic Exempt-Medic commented Nov 25, 2024 •
edited
Loading

What is this fixing or adding?

all_event_names is a set and iterating over a set is nondeterministic. This sorts the set.
Yes, they're events, so it doesn't really matter, I hope, but it's an easy change.

How was this tested?

Generations and the Determinism Test PR

@qwint @BadMagic100

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 25, 2024
@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Nov 25, 2024
qwint
qwint approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last it was discussed this was safe because it only changed spoiler log output order,
but i also see no reason not to sort

@NewSoupVi NewSoupVi merged commit 41a7d7e into ArchipelagoMW:main Nov 25, 2024
18 checks passed
@Exempt-Medic Exempt-Medic deleted the hk-determinism branch November 26, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@qwint qwint qwint approved these changes

@BadMagic100 BadMagic100 Awaiting requested review from BadMagic100

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Exempt-Medic @qwint @NewSoupVi