Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix Fill choking on itself in minimal + full games #4225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

Core: Fix Fill choking on itself in minimal + full games #4225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bca1cb
Fix Fill choking on itself in minimal + full games
NewSoupVi Nov 22, 2024
26c1e9b
Remove the overindentation
NewSoupVi Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Fill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,12 @@ def fill_restrictive(multiworld: MultiWorld, base_state: CollectionState, locati
base_state, [], multiworld.get_filled_locations(item.player)
if single_player_placement else None)
for placement in placements:
if multiworld.worlds[placement.item.player].options.accessibility != "minimal" and not placement.can_reach(state):
if (
multiworld.worlds[placement.item.player].options.accessibility != "minimal"
# accessibility_corrections can clean up the case where the location's player is minimal
and multiworld.worlds[placement.player].options.accessibility != "minimal"
and not placement.can_reach(state)
):
placement.item.location = None
unplaced_items.append(placement.item)
placement.item = None
Expand Down
Loading