Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zillion: new priority dead ends feature #4220

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Zillion: new priority dead ends feature #4220

wants to merge 6 commits into from

Conversation

beauxq
Copy link
Collaborator

@beauxq beauxq commented Nov 21, 2024 •
edited
Loading

What is this fixing or adding?

a new option

How was this tested?

a few play-throughs
looked at options page on webhost

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 21, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Nov 21, 2024
@Exempt-Medic
Copy link
Member

I assume it's fine/intended that if a player adds one of these to exclude_locations, that exclusion takes priority over the prioritization here?

Exempt-Medic
Exempt-Medic approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments (one in the server about option checking) and one here about excluded locations. Tested the changes locally and saw the proper locations were made into priority. The code LGTM and the prioritization happens at good stage of generation.

@beauxq
Copy link
Collaborator Author

beauxq commented Dec 3, 2024

I assume it's fine/intended that if a player adds one of these to exclude_locations, that exclusion takes priority over the prioritization here?

Yeah, that prioritization sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beauxq @Exempt-Medic